Keyboard 'tab' key navigation improved#4244
Conversation
tdonohue
added
accessibility
1 APPROVAL
|
@oscar-escire : Thanks! Sorry, I didn't realize you had started work on this. I had assigned this to @pcg-kk in today's Developers meeting to look into. But, maybe @pcg-kk could just help to review or test this PR instead. I'll see if I can also find time to give this a try soon too. |
|
@tdonohue I will make a review of that today - no problem 👍 |
pcg-kk
left a comment
pcg-kk
left a comment
There was a problem hiding this comment.
This PR introduces significant improvements for Safari browser compatibility, addressing several rendering and functionality issues that were specific to this browser.
|
@tdonohue my approval doesn't change the review status and it's still required. Is it normal? |
tdonohue
moved this from 🙋 Needs Reviewers Assigned
to 👍 Reviewer Approved
in DSpace 9.0 Release
|
@pcg-kk : I've moved it manually to the "Reviewer Approved" status column. Unfortunately, GitHub doesn't always pickup approvals from everyone and move the PR appropriately on the board, so I occasionally have to move it manually. Thanks for your review/test. I'll give this a quick sanity check that it doesn't impact behavior on other browsers & then get it merged. |
tdonohue
changed the title
tdonohue
added
the
port to dspace-8_x
tdonohue
left a comment
tdonohue
left a comment
There was a problem hiding this comment.
👍 Thanks @oscar-escire ! While I don't have Safari to test with, I tested this in a few other browsers (Chrome & Firefox) to ensure it has no negative side effects. The code also looks good to me.
Because this is an accessibility fix, it would be nice to see if this can be backported to 8.x and possibly 7.6.x. I've flagged it as such. However, it's possible it would need a manual backport.
tdonohue
added
the
port to dspace-7_x
github-project-automation
Bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace 9.0 Release
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-7_x
git worktree add -d .worktree/backport-4244-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-4244-to-dspace-7_x
git switch --create backport-4244-to-dspace-7_x
git cherry-pick -x f8cfb74555894e8e5982d63bd3007bab19d4cd84 4e5b344ce8c5224713fde612b3440d0181871361 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-4244-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-4244-to-dspace-8_x
git switch --create backport-4244-to-dspace-8_x
git cherry-pick -x f8cfb74555894e8e5982d63bd3007bab19d4cd84 4e5b344ce8c5224713fde612b3440d0181871361 |
|
@oscar-escire : If you are willing/interested in backporting this to the |
tdonohue
removed
port to dspace-7_x
4 participants
References
Hi @tdonohue I've been working on this PR and i like to share it with you
Add references/links to any related issues or PRs. These may include:
Description
This PR improves tab navigation across the Dspace site, primarily targeting browsers like Safari that require explicit tags to properly detect the next focusable element.
Instructions for Reviewers
List of changes in this PR:
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.